Use ml4gw for generating testing waveforms #381
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* hotfix for gdb server * remove redundant information * fix logging typo * improve logging * fix url bug * fix out dir variable name in monotir cli * use ligo.skymap 2.4.0 to show interferometers in skymap * bug fixes * add matmul precision argument * remove debug logging statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes PyCBC and uses ml4gw to generate waveforms used for validation and testing. This is based on the faster rejection sampling, and there doesn't seem to be much difference in generation speeds, based on an extremely unrigorous test: on a head node, rejection-sampling 100 waveforms took about 90 seconds for both libraries.
Once #379 is merged, I'll rebase this PR on main.