feat(resource-display.php): add allow-reservations config for tablet … #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view Introduces a new configuration option 'tablet.view.allow.reservations' to control whether reservations can be made from the tablet view. Updates backend logic, templates, and tests to respect this setting, conditionally rendering reservation UI and blocking reservation actions when disabled. Removes unnecessary code related to previous UI handling due to the Bootstrap 5 update.
JohnVillalovos
force-pushed
the
feature/reservations-toggle-in-resource-display
branch
from
ad740a7 to
743f1dc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new configuration option tablet.view.allow.reservations that enables administrators to control whether users can make reservations from the tablet view. The feature provides a way to disable the reservation functionality while still allowing users to view resource availability.
Changes:
- Added new configuration key
TABLET_VIEW_ALLOW_RESERVATIONSwith default valuetrue - Updated backend logic to check the configuration and block reservation attempts when disabled
- Modified templates to conditionally render the reservation UI based on the configuration
- Cleaned up deprecated JavaScript code related to Bootstrap 5 migration
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/Config/ConfigKeys.php | Defines the new TABLET_VIEW_ALLOW_RESERVATIONS configuration constant |
| config/config.dist.php | Adds the configuration option to the distribution config file |
| .env.example | Adds the environment variable for the new configuration |
| Presenters/ResourceDisplayPresenter.php | Implements backend validation to block reservations when disabled; includes code style improvements |
| Pages/ResourceDisplayPage.php | Passes the configuration value to the template for UI rendering |
| tpl/ResourceDisplay/resource-display-shell.tpl | Updates modal ID and adds min/default date parameters to DatePicker |
| tpl/ResourceDisplay/resource-display-resource.tpl | Wraps reservation UI in conditional block based on configuration; adjusts spacing |
| Web/scripts/resourceDisplay.js | Removes commented-out code related to deprecated popup handling; updates date picker reference |
| tests/TestBase.php | Sets the new configuration to true by default in test setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec for the improvements!
LGTM.
labmecanicatec
deleted the
feature/reservations-toggle-in-resource-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…view
Introduces a new configuration option 'tablet.view.allow.reservations' to control whether reservations can be made from the tablet view. Updates backend logic, templates, and tests to respect this setting, conditionally rendering reservation UI and blocking reservation actions when disabled. Removes unnecessary code related to previous UI handling due to the Bootstrap 5 update.