Optimize SND data import #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Want to ensure the importRows code path is only triggered by the initial data load 2. Changed criteria to look at the number of events instead of the number of eventData or AttributeData rows
RameshRapa
reviewed
Feb 20, 2025
RameshRapa
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The importRows code path is failing with duplicate EventId errors. This code path was introduced to speed up the code when the SND data is initially loaded on the server. Unfortunately, a recent change to reduce the MAX_MERGE_ROWS has caused this code path to be taken in other situations.
We need to ensure the importRows code path is only triggered by the initial data load.
Changes
Updated mergeRows in EventDataTable and AttributeDataTable.