Workflow Automation: Task action to filter samples for selected task #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Dec 22, 2025
| }); | ||
|
|
||
| it('excludes read-only action values when lockReadOnlyForDelete is true', () => { | ||
| const result = filterActionValuesByType(mockActionValues, 'search', true); |
Contributor
There was a problem hiding this comment.
Should this be looking for 'filter' instead of 'search'?
| }); | ||
|
|
||
| it('returns non-readonly filter action values when lockReadOnlyForDelete is true', () => { | ||
| const result = filterActionValuesByType(mockActionValues, 'filter', true); |
Contributor
There was a problem hiding this comment.
Same as test on line 64?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This pull request adds workflow automation features for task actions to filter samples, introducing a new capability to lock read-only filters and prevent their deletion. The changes also include a significant refactoring of the FieldFilter interface to EntityFieldFilter for better semantic clarity.
Related Pull Requests
Changes
lockReadOnlyForDeleteprop for workflow filter components to prevent modification of read-only filters used for deletion.EntityFieldFiltertype (renamed fromFieldFilter) for improved clarity and consistency across workflow task filters.getActionValuesForFilterPropsandremoveFilterValueForFilterPropsto simplify reading and updating filter values.supportAllValueInQueryin entity data types so workflow filters can include an "All" option when querying entities.