Provides a more reliable method of tracking the player associated with an entity damage and death event #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still fallback to last damage event damager if null. It doesn't really fix LMBishop#752, however possibly allows for Fire Aspect tracking of entities ignited within last 5 seconds (similarly to different built-in game mechanics).
# Conflicts: # bukkit/src/main/java/com/leonardobishop/quests/bukkit/tasktype/type/MobkillingTaskType.java
…th entity damage and death.
Collaborator
|
Tbh, storing any persistent data on blocks, entities and other just for Quests completion is a big no-no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #752 by using Entity#getPersistentDataContainer to store the player that last hit an entity and then using that stored value in both dealing with entity damage and entity death events. This gets around the five second limit built into the Entity#getKiller function.