Skip to content

Add signing time to VerificationInfo #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
datspike wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add signing time to VerificationInfo #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b2855c9
Add sign time to pVerifyInfo
Jul 19, 2022
40a4841
Add sign time to pVerifyInfo
Jul 19, 2022
9aa8995
Add sign time to VerificationInfoDetached
Jul 19, 2022
f57f5f6
Fix exception on failed verification
Aug 23, 2022
edab18d
Bump version to 1.0.1
Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pycryptoprosdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,15 @@ def __init__(self, verification_info):
self._verification_info = verification_info

self.verification_status = self._verification_info['verificationStatus']
self.signing_time = self._get_signing_time()
self.cert = self._get_cert()
self.error = self._verification_info['error']

def _get_signing_time(self):
if self.verification_status == -1:
return
return self._verification_info.get('signingTime')

def _get_cert(self):
if self.verification_status == -1:
return
Expand Down
2 changes: 2 additions & 0 deletions pycryptoprosdk/libpycades.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,7 @@ static PyObject * Verify(PyObject *self, PyObject *args) {
if (pVerifyInfo) {
PyDict_SetItemString(res, "verificationStatus", PyLong_FromLong(pVerifyInfo->dwStatus));
PyDict_SetItemString(res, "certInfo", GetCertInfo(pVerifyInfo->pSignerCert));
PyDict_SetItemString(res, "signingTime", FileTimeToPyDateTime(pVerifyInfo->pSigningTime));

if (pVerifyInfo->dwStatus == 0) {
DWORD contentLength = 0;
Expand Down Expand Up @@ -544,6 +545,7 @@ static PyObject * VerifyDetached(PyObject *self, PyObject *args)
if (pVerifyInfo) {
PyDict_SetItemString(res, "verificationStatus", PyLong_FromLong(pVerifyInfo->dwStatus));
PyDict_SetItemString(res, "certInfo", GetCertInfo(pVerifyInfo->pSignerCert));
PyDict_SetItemString(res, "signingTime", FileTimeToPyDateTime(pVerifyInfo->pSigningTime));

CadesFreeVerificationInfo(pVerifyInfo);
}
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

setup(
name='pycryptoprosdk',
version='1.0.0',
version='1.0.1',
url='https://github.com/Keyintegrity/pycryptoprosdk',
author='uishnik',
author_email='uishnik@yandex.ru',
Expand Down