Skip to content

Parse string escape sequences #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Arnaz87 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Parse string escape sequences #16

Arnaz87 wants to merge 2 commits into from

Conversation

@Arnaz87
Copy link

@Arnaz87 Arnaz87 commented Jan 29, 2019

Fixes #10

Keats
Keats requested changes Jan 31, 2019
View reviewed changes
README.md Outdated
str = "The dog says \"woof\"."
```
As you can see, double quotes have to be escaped if used in basic strings.
As you can see, double quotes have to be escaped if used in basic strings. Valid escape secuences are quotes with `\"`, newlines with `\n` and two digit hexadecimal characters with `\x00`.
Copy link
Owner

@Keats Keats Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequences

parser/src/parser.rs
}

result
}
Copy link
Owner

@Keats Keats Jan 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function will need to return a Result seeing the number of things that can panic, unless they are all cases prevented by the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keats Keats Keats requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arnaz87 @Keats