Skip to content

Conversation

@Imabanana80
Copy link

basic materialgroups enum with the 4 basic tools and sword (for now)

omg imabanana80 makes his actual first pr!!

basic materialgroups enum with the 4 basic tools and sword (for now)
@Kyren223 Kyren223 self-assigned this Sep 13, 2024
Copy link
Member

@Kyren223 Kyren223 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Commit message should be more descriptive
  • Groups should be plural (AXES not AXE)
  • All elements annotated with @Kapi should have a javadoc
  • Constructors should follow the style guidelines
 SWORDS(Set.of(
    Material.WOODEN_SWORD,
    Material.STONE_SWORD,
    Material.IRON_SWORD,
    Material.DIAMOND_SWORD,
    Material.GOLDEN_SWORD,
    Material.NETHERITE_SWORD
)),

@Imabanana80 Imabanana80 changed the title feat: materialgroups MaterialGroups Sep 14, 2024
@Kyren223
Copy link
Member

Will be waiting for more groups other than the initial tools before merging.
here are some ideas:
Tools
Weapons
Mob eggs
Ingots
Ores

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants