-
-
Notifications
You must be signed in to change notification settings - Fork 4
MaterialGroups #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Imabanana80
wants to merge
9
commits into
KapiMC:master
Choose a base branch
from
Imabanana80:materialgroup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basic materialgroups enum with the 4 basic tools and sword (for now)
Kyren223
requested changes
Sep 13, 2024
Member
Kyren223
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Commit message should be more descriptive
- Groups should be plural (AXES not AXE)
- All elements annotated with @Kapi should have a javadoc
- Constructors should follow the style guidelines
SWORDS(Set.of(
Material.WOODEN_SWORD,
Material.STONE_SWORD,
Material.IRON_SWORD,
Material.DIAMOND_SWORD,
Material.GOLDEN_SWORD,
Material.NETHERITE_SWORD
)),
Kyren223
approved these changes
Sep 14, 2024
Member
|
Will be waiting for more groups other than the initial tools before merging. |
ac8f8c6 to
605ed53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic materialgroups enum with the 4 basic tools and sword (for now)
omg imabanana80 makes his actual first pr!!