header passing mechanism shifted to browser cookies #840
+436
−578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suggestions and other fixes
abchugh
reviewed
Dec 30, 2025
spec/src/lib/lmp.ts
Outdated
| } | ||
|
|
||
| const SERVER_TO_ADDRESS = { | ||
| export const SERVER_TO_ADDRESS = { |
Collaborator
There was a problem hiding this comment.
This is not a good name when it is exported. Take a look at this import:
import { SERVER_TO_ADDRESS } from '@alea/spec';
the name doesn't tell you which servers it is referring to (but did makes sense when it was limited to this file).
I would actually suggest moving this to the lmp-redirect.ts API where it is needed (and not export it at all). Here we can just use process.env['NEXT_PUBLIC_AUTH_SERVER_URL']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.