Skip to content

Conversation

@JeffFessler
Copy link
Member

The existing lilyplay example would not run due to an apparently obsolete reference to maxoutchans.
This PR fixes that and adds a brief comment to explain what the file does.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #106 (d702d4e) into master (f6cd300) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files           2        2           
  Lines         342      342           
=======================================
  Hits          334      334           
  Misses          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6cd300...d702d4e. Read the comment docs.

@JeffFessler
Copy link
Member Author

Can be closed in favor of the more comprehensive #107.
I don't have any experience with Makie so I won't be any help there, sorry!

@JeffFessler
Copy link
Member Author

BTW, the default tests include 1.4 and 1.5 (in many OS flavors). Now that 1.6 is the LTS we could save some carbon footprint by just testing (say) 1.3, 1.6, 1 and nightly if you want.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant