Skip to content

Conversation

@rodwyer100
Copy link
Contributor

I have revamped the tracking processor to include the residuals and kink collections. I need this pushed so that I can incorporate them into the tight selection code I am devising.

@mgignac
Copy link
Collaborator

mgignac commented Feb 6, 2025

Hi @rodwyer100 ,
Thank for the updates. They look fine to me, but I am a bit concerned that the changes to the Track class will mean that the HPSTR files produced for the 1% pass will not longer be readable with this update. So we should proceed with a bit of caution before merging this in.

Can you comment on how urgent it is to get this into master? I'm thinking it may be best to wait a few weeks before we merge this in. And maybe you can continue to work on your branch for the next few weeks? Then we can include these changes in preparation for the 10% processing?

Cheers,
Matthew

@rodwyer100
Copy link
Contributor Author

These are not urgent per say. Sarah will need these as well, but when she gets ready for implementing tight selection on her end she can pull my branch (or should be able to)

@mholtrop
Copy link
Collaborator

I concur with Matthew. This is the second (third?) time this year that someone would like to change the root data format in a not backwards compatible manner. There clearly is a need for a mechanism to change the data content of the root files without breaking code or making older root files obsolete.
I think we should have a discussion on how to do this. I would suggest this is done with custom streamers for each class, writing and reading the root files in a class agnostic way, i.e. the root file no longer depends on the details classes and the contends of the root file can be read without needing to load the classes. BUT, that would be a more significant re-tooling of hpstr. The advantage is that then the content of the files can then be changed without breaking previous code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants