refactor: Standardize root_path access pattern across codebase #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all `request.scope.get("root_path", "")` with `settings.app_root_path`
- Add trailing slashes to redirect URLs to avoid unnecessary 307 redirects
- Add settings import to llm_admin_router.py
Files affected:
- mcpgateway/admin.py (76 occurrences)
- mcpgateway/utils/verify_credentials.py (3 occurrences)
- mcpgateway/routers/sso.py (1 occurrence)
- mcpgateway/routers/oauth_router.py (1 occurrence)
- mcpgateway/routers/llm_admin_router.py (5 occurrences)
Closes IBM#1588
Signed-off-by: William <you@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.scope.get("root_path", "")withsettings.app_root_pathFiles affected:
Closes #1588
📝 Pull Request Template Selection
Thank you for contributing! To help us review your pull request effectively, please select the appropriate template (go to the
Previewtab and select the appropriate sub-template):Alternatively, after opening your pull request, you can choose the appropriate template from the "Choose a template" dropdown menu located at the top-right of the description box.
If none of the above templates fit your changes, feel free to provide a clear and concise description of your pull request below.