Skip to content

Conversation

@casperisfine
Copy link

@casperisfine casperisfine commented Sep 6, 2024

Otherwise it fails with:

LoadError: /tmp/bundle/ruby/3.4.0+0/gems/tiktoken_ruby-0.0.8/lib/tiktoken_ruby/tiktoken_ruby.so:
undefined symbol: ruby_abi_version - ruby_abi_version (LoadError)

However compilation is now failing with:

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_1`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:366:57
    |
366 |             slice::from_raw_parts(h.ptr as *const u8, h.len as usize)
    |                                                         ^^^ unknown field
    |
    = note: available fields are: `ptr`, `aux`

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_1`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:954:19
    |
954 |                 h.len as usize
    |                   ^^^ unknown field
    |
    = note: available fields are: `ptr`, `aux`

error[E0609]: no field `len` on type `RString__bindgen_ty_1__bindgen_ty_2`
   --> /Users/byroot/.cargo/registry/src/index.crates.io-6f17d22bba15001f/magnus-0.4.4/src/r_string.rs:996:44
    |
996 |     value.as_internal().as_ref().as_.embed.len
    |                                            ^^^ unknown field
    |
    = note: available field is: `ary`

For more information about this error, try `rustc --explain E0609`.

Which I don't know how to fix. @ianks could you lend me a hand here?

@casperisfine
Copy link
Author

Nevermind, the compilation failure was because I forgot to rebase my fork 🤦

Otherwise it fails with:

```
LoadError: /tmp/bundle/ruby/3.4.0+0/gems/tiktoken_ruby-0.0.8/lib/tiktoken_ruby/tiktoken_ruby.so:
undefined symbol: ruby_abi_version - ruby_abi_version (LoadError)
```
@casperisfine
Copy link
Author

Hum, seems like there's no version of rb-sys compatible with both 3.4 and 2.7?

@ianks
Copy link

ianks commented Sep 7, 2024

Hum, seems like there's no version of rb-sys compatible with both 3.4 and 2.7?

rb-sys is (painfully) compatible down to 2.6

I think this error is a bundler issue?

  	There are no versions of bundler (= 2.5.18) compatible with your Ruby & RubyGems
  	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.225.

Anyway, @IAPark we should probably drop 2.7 support since it's EOL and rb-sys will

@ianks
Copy link

ianks commented Sep 7, 2024

@IAPark just saw you are looking for maintainership help. Happy to lend a hand here if you send inv ❤️

@gjtorikian gjtorikian force-pushed the bump-rb-sys branch 3 times, most recently from 5c93f0a to 4eced23 Compare December 29, 2024 16:02
@gjtorikian gjtorikian mentioned this pull request Dec 29, 2024
@gjtorikian
Copy link
Collaborator

Thanks y'all.

@gjtorikian gjtorikian merged commit c0ac083 into IAPark:main Dec 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants