Changes to recalculation #2578
Open
Changes to recalculation #2578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this ready to be reviewed @barreiro ? |
refactored calculateDatapoints and runChangeDetection removed calls to executeBlocking, only one useage of messageBus remaining
barreiro
force-pushed
the
deadlock_investigation
branch
from
a6111c6 to
18a8e18
Compare
Collaborator
Author
|
rebased and fixed the failing test... it's ready now! |
lampajr
requested changes
Nov 27, 2025
Member
lampajr
left a comment
lampajr
left a comment
There was a problem hiding this comment.
I just started reviewing it and I found this:
- When you click "save" on "Change detection" tab, you can recalculate all datapoints but since now the computation is more synchronous the progress bar does not reflect the real status it goes from 0 to 100 as soon as completed
I believe this should be properly adapted to the new logic.
I will keep reviewing it..
Member
|
I did some other tests trying to recalculate datapoints/changes and the first results look, so I believe that once the issue I shared is sorted out we could try to merge it and you can see in staging (with ~prod like data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Improves how the change detection is performed.
This PR incorporates #2559
Changes proposed
A new event and queue is used to decouple change detection from datapoint creation.
Change detection now is done in one go, instead of the previous algorithm.
Check List (Check all the applicable boxes)