-
Notifications
You must be signed in to change notification settings - Fork 0
Subsystem/shooter flywheel #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
spellingcat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty close. i'm gonna have you coordinate w jason tomorrow hopefully if y'all can both make it to start writing the code that will control both the hood + rollers at the same time
| HoodIOInputsAutoLogged hoodinputs = new HoodIOInputsAutoLogged(); | ||
|
|
||
| RollerIOReal rollerIO; | ||
| RollerIOInputsAutoLogged rollerinputs = new RollerIOInputsAutoLogged(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| RollerIOInputsAutoLogged rollerinputs = new RollerIOInputsAutoLogged(); | |
| RollerIOInputsAutoLogged rollerInputs = new RollerIOInputsAutoLogged(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would perhaps rename these variables to flywheelIO and flywheelInputs (to be clear, it's still of type RollerIOReal- flywheel would just be in the name of the variables)
| public void periodic() { | ||
| hoodIO.updateInputs(hoodinputs); | ||
| Logger.processInputs("hood", hoodinputs); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remember to call updateInputs and processInputs for the flywheel as well (here's why that's important if you want a refresher)
…anderRobotics/Rebuilt into subsystem/shooter-flywheel
No description provided.