Skip to content

Conversation

@BlazingBora
Copy link

No description provided.

Copy link
Member

@spellingcat spellingcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty close. i'm gonna have you coordinate w jason tomorrow hopefully if y'all can both make it to start writing the code that will control both the hood + rollers at the same time

HoodIOInputsAutoLogged hoodinputs = new HoodIOInputsAutoLogged();

RollerIOReal rollerIO;
RollerIOInputsAutoLogged rollerinputs = new RollerIOInputsAutoLogged();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RollerIOInputsAutoLogged rollerinputs = new RollerIOInputsAutoLogged();
RollerIOInputsAutoLogged rollerInputs = new RollerIOInputsAutoLogged();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would perhaps rename these variables to flywheelIO and flywheelInputs (to be clear, it's still of type RollerIOReal- flywheel would just be in the name of the variables)

public void periodic() {
hoodIO.updateInputs(hoodinputs);
Logger.processInputs("hood", hoodinputs);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to call updateInputs and processInputs for the flywheel as well (here's why that's important if you want a refresher)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants