Bugfixes on streaming #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoSanti
force-pushed
the
streaming-bugfixes
branch
from
dee26c7 to
3dec221
Compare
This commit fixes a bug in the streaming logic. Previusly when a consumer step tried to open a file that did not exist yet, an error code was returned to the poix application, instead of halting the execution until the file was present. This has now been fixed by spawning a new thread to wait for the creation of the new file. Another issue that this commit fixes is a missing negation of a condition on the read handler, which prevented streaming to correctly occur.
marcoSanti
force-pushed
the
streaming-bugfixes
branch
from
3dec221 to
2aaebec
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 56.34% 56.32% -0.02%
==========================================
Files 71 71
Lines 3429 3444 +15
Branches 2126 2133 +7
==========================================
+ Hits 1932 1940 +8
- Misses 578 579 +1
- Partials 919 925 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug in the streaming logic. Previously, when a consumer step attempted to open a file that did not yet exist, an error code was returned to the POSIX application instead of blocking execution until the file became available. This has been fixed by spawning a new thread that waits for the file to be created.
This commit also rewrites the internal logic of the handle_local_read() to fix streaming issues and to make it more understandable.