Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Conversation

@yueawang
Copy link

@yueawang yueawang commented Oct 1, 2020

Hi, HarryR

I found the point compression code is inconsistent with the doc description, so I make some change based on https://ed25519.cr.yp.to/eddsa-20150704.pdf.

changes are:

specifically, x is negative if the (b − 1)-bit encoding of x is lexicographically larger than the (b − 1)-bit encoding of −x.

and

This encoding is also used to define a b-bit encoding of each element (x, y) ∈ E as a b-bit string (x, y), namely the (b − 1)-bit encoding of y followed by a sign bit; the sign bit is 1 if and only if x is negative.

Please correct me if I am wrong.
Thanks!

Signed-off-by: yue.wang yue.wang@loopring.io

Signed-off-by: yue.wang <yue.wang@loopring>
Signed-off-by: yue.wang <yue.wang@loopring>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant