Auto Tab #27
Open
Auto Tab #27
+166
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2026 21:13
YoniKiriaty
requested changes
Jan 28, 2026
added 2 commits
January 28, 2026 17:07
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {isAuto && ( | ||
| <> | ||
| <button | ||
| className={`bg-${(currentMovement as ScoutingForm["auto"]["movement"]).trenchPass ? "rose-500" : "slate-800"} m-1 w-32 h-16 px-2`} |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
| onClick={() => { | ||
| setMovement({ | ||
| ...currentMovement, | ||
| trenchPass: !(currentMovement as ScoutingForm["auto"]["movement"]).trenchPass, |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
| Pass Trench | ||
| </button> | ||
| <button | ||
| className={`bg-${(currentMovement as ScoutingForm["auto"]["movement"]).bumpPass ? "rose-500" : "slate-800"} m-1 w-32 h-16 px-2`} |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
| onClick={() => { | ||
| setMovement({ | ||
| ...currentMovement, | ||
| bumpPass: !(currentMovement as ScoutingForm["auto"]["movement"]).bumpPass, |
Check warning
Code scanning / ESLint
Disallow type assertions that narrow a type Warning
YoniKiriaty
requested changes
Jan 28, 2026
Comment on lines
+58
to
+70
| const imageBounds = | ||
| containerRatio > mapAspectRatio | ||
| ? { | ||
| width: bound.height * mapAspectRatio, | ||
| height: bound.height, | ||
| offsetX: (bound.width - bound.height * mapAspectRatio) / HALF_HEIGHT, | ||
| offsetY: 0, | ||
| } | ||
| : { | ||
| width: bound.width, | ||
| height: bound.width / mapAspectRatio, | ||
| offsetX: 0, | ||
| offsetY: (bound.height - bound.width / mapAspectRatio) / HALF_HEIGHT, |
Contributor
There was a problem hiding this comment.
consider using either css or tailwind to do this on the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.