pre match #22
Open
pre match #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karnishein
requested changes
Jan 26, 2026
Comment on lines
+13
to
+15
| const Buttons: FC<{ | ||
| form: ScoutingForm; | ||
| setForm: Dispatch<SetStateAction<ScoutingForm>>; | ||
| }> = ({ form, setForm }) => { |
Contributor
There was a problem hiding this comment.
please consider using an interface for this
apps/scouting/frontend/src/hhh.tsx
Outdated
Comment on lines
18
to
24
| <div | ||
| style={{ | ||
| display: "flex", | ||
| flexDirection: "column", | ||
| gap: "20px", | ||
| width: "700px", | ||
| }} | ||
| className="mx-auto my-auto" |
Contributor
There was a problem hiding this comment.
consider using one consistent for you styles (css/ style/ tailwind)
Comment on lines
+58
to
+57
| min="0" | ||
| max="16383" |
Comment on lines
27
to
29
| const onScanFailure = (error: any) => { | ||
| // שגיאות סריקה רגילות (כשהמצלמה לא מוצאת קוד) - בד"כ מתעלמים | ||
| }; |
Contributor
There was a problem hiding this comment.
consider printing an error message to the console or putting some error message in red on the scouting screen
| @@ -0,0 +1,29 @@ | |||
| const Buttons = () => { | |||
Comment on lines
+3
to
+6
| <div style={styles.container}> | ||
| <input type="text" placeholder="טקסט 1" style={styles.input} /> | ||
| <input type="text" placeholder="טקסט 2" style={styles.input} /> | ||
| <input type="text" placeholder="טקסט 3" style={styles.input} /> |
Contributor
There was a problem hiding this comment.
please write this in English
Comment on lines
+21
to
+22
| border: "2px solid #22c55e", // ירוק | ||
| backgroundColor: "#000", // שחור |
Contributor
There was a problem hiding this comment.
please remove these comments
| @@ -0,0 +1,29 @@ | |||
| const Buttons = () => { | |||
Contributor
There was a problem hiding this comment.
consider removing the changes from the template
| @@ -0,0 +1,31 @@ | |||
| const Buttons = () => { | |||
Contributor
There was a problem hiding this comment.
consider removing the changes from the template
yuval20100
force-pushed
the
scouting/feat/pre-match
branch
3 times, most recently
from
ae60d2e to
5cfcf20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.