Skip to content

Conversation

@pratickchokhani
Copy link
Contributor

… for numerical Infinity and Nan values.

@gemini-code-assist
Copy link

Summary of Changes

Hello @pratickchokhani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial integration test for the Spanner to SourceDB pipeline, specifically targeting the robust handling of numerical boundary conditions during reverse replication. The new test case ensures that extreme numerical values, including positive and negative infinity, as well as Not-a-Number (NaN) values, are accurately replicated from Spanner to MySQL, thereby enhancing the data integrity and reliability of the replication process for complex numerical data types.

Highlights

  • New Integration Test: An integration test has been added to verify the correct handling of numerical boundary values (Infinity and NaN) during Spanner reverse replication to MySQL.
  • Schema Updates: New test tables, BoundaryConversionTestTable, have been introduced in both Spanner and MySQL schemas to support the new test case.
  • Comprehensive Value Testing: The test covers Byte, Short, Integer, Long min/max values, Float and Double positive/negative infinity and NaN, and boundary BigDecimal values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pratickchokhani pratickchokhani added bug Something isn't working bug-fix and removed bug Something isn't working labels Jan 7, 2026
@pratickchokhani pratickchokhani force-pushed the mysql_boundary_check branch 2 times, most recently from 81fd4ce to 69d1241 Compare January 7, 2026 05:54
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.86%. Comparing base (368d6f5) to head (ec81dac).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3198      +/-   ##
============================================
+ Coverage     50.80%   50.86%   +0.06%     
- Complexity     5124     5133       +9     
============================================
  Files           976      976              
  Lines         60058    60092      +34     
  Branches       6569     6572       +3     
============================================
+ Hits          30511    30567      +56     
+ Misses        27406    27374      -32     
- Partials       2141     2151      +10     
Components Coverage Δ
spanner-templates 71.02% <100.00%> (+0.02%) ⬆️
spanner-import-export 68.99% <ø> (ø)
spanner-live-forward-migration 80.12% <ø> (+0.02%) ⬆️
spanner-live-reverse-replication 77.77% <100.00%> (+0.05%) ⬆️
spanner-bulk-migration 88.44% <ø> (ø)
Files with missing lines Coverage Δ
...rt/v2/templates/dbutils/dml/MySQLDMLGenerator.java 88.44% <100.00%> (+0.10%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratickchokhani pratickchokhani force-pushed the mysql_boundary_check branch 2 times, most recently from ade723a to 5b960e4 Compare January 8, 2026 07:08
@pratickchokhani pratickchokhani force-pushed the mysql_boundary_check branch 4 times, most recently from ec81dac to 5dd1946 Compare January 8, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant