-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test(Spanner): In spanner reverse replication, added integration test… #3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test(Spanner): In spanner reverse replication, added integration test… #3198
Conversation
Summary of ChangesHello @pratickchokhani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a crucial integration test for the Spanner to SourceDB pipeline, specifically targeting the robust handling of numerical boundary conditions during reverse replication. The new test case ensures that extreme numerical values, including positive and negative infinity, as well as Not-a-Number (NaN) values, are accurately replicated from Spanner to MySQL, thereby enhancing the data integrity and reliability of the replication process for complex numerical data types. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
81fd4ce to
69d1241
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3198 +/- ##
============================================
+ Coverage 50.80% 50.86% +0.06%
- Complexity 5124 5133 +9
============================================
Files 976 976
Lines 60058 60092 +34
Branches 6569 6572 +3
============================================
+ Hits 30511 30567 +56
+ Misses 27406 27374 -32
- Partials 2141 2151 +10
🚀 New features to boost your workflow:
|
ade723a to
5b960e4
Compare
ec81dac to
5dd1946
Compare
… for numerical Infinity and Nan values.
5dd1946 to
dc38079
Compare
… for numerical Infinity and Nan values.