Skip to content

Conversation

@derrickaw
Copy link
Contributor

@derrickaw derrickaw commented Jan 2, 2026

  1. Previous submitted PR Add PubSubToBigTable blueprint/template #3150 didn't contain all the available parameters for maximum flexibility.
  2. This PR adds all parameters.
  3. Addresses this comment Add PubSubToBigTable blueprint/template #3150 (comment)

@gemini-code-assist
Copy link

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the PubSubToBigTable YAML template by integrating a comprehensive set of new configuration parameters. These additions provide users with greater control over how Pub/Sub messages are processed and mapped to BigTable, enabling more flexible and robust data ingestion pipelines. The changes span across the Java interface, Python generation scripts, and the YAML definitions themselves to ensure full parameter exposure and functionality.

Highlights

  • Expanded Template Parameters: The PubSubToBigTable YAML template now supports a significantly broader range of Pub/Sub and BigTable configuration parameters, including options for attribute handling, message deduplication, timestamp attributes, error handling, and BigTable flattening.
  • Required Format Parameter: The format parameter for Pub/Sub messages has been updated to be a required field, ensuring that the message format is explicitly defined.
  • Python Script Enhancements: The generate_yaml_java_templates.py script was updated to provide more detailed error output for Maven spotless failures and includes minor refactoring for variable names.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@derrickaw derrickaw added addition New feature or request improvement and removed addition New feature or request labels Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.77%. Comparing base (4328a13) to head (e72ca76).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3177      +/-   ##
============================================
- Coverage     50.80%   50.77%   -0.04%     
+ Complexity     5118     5114       -4     
============================================
  Files           976      976              
  Lines         59996    59996              
  Branches       6555     6555              
============================================
- Hits          30483    30462      -21     
- Misses        27377    27393      +16     
- Partials       2136     2141       +5     
Components Coverage Δ
spanner-templates 70.93% <ø> (-0.08%) ⬇️
spanner-import-export 68.84% <ø> (-0.17%) ⬇️
spanner-live-forward-migration 80.02% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 77.68% <ø> (-0.07%) ⬇️
spanner-bulk-migration 88.47% <ø> (-0.02%) ⬇️
see 9 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review January 2, 2026 19:26
@derrickaw derrickaw requested a review from tarun-google January 2, 2026 19:26
@derrickaw derrickaw merged commit 5de840a into GoogleCloudPlatform:main Jan 3, 2026
17 of 19 checks passed
@derrickaw derrickaw deleted the fixPubSubToBigTable branch January 3, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants