-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Flex templates of same dependencies sharing container image #3172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Flex templates of same dependencies sharing container image #3172
Conversation
Summary of ChangesHello @Abacn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant optimizations to the Maven plugin responsible for staging Google Cloud Dataflow Flex Templates. The primary goal is to enhance efficiency by ensuring that container images shared by multiple templates are built and processed only once. This is achieved through the implementation of a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (7.59%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
============================================
+ Coverage 50.86% 50.87% +0.01%
- Complexity 5133 5512 +379
============================================
Files 976 976
Lines 60090 60144 +54
Branches 6572 6584 +12
============================================
+ Hits 30564 30599 +35
- Misses 27374 27391 +17
- Partials 2152 2154 +2
🚀 New features to boost your workflow:
|
2a5998e to
7fe9f9f
Compare
80e700e to
53ea460
Compare
* Support ContainerStageTracker for Java and XLang Templates
53ea460 to
3b62ba0
Compare
| */ | ||
| public class DockerfileGenerator { | ||
|
|
||
| // TODO(DO NOT MERGE) - testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark here --- switch to released image when the internal change promoted to prod
Part of #2279. Allow different flex templates sharing a launcher image, which builds only once during a release build