Skip to content

feat: context aware concurrent S3 #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bpeng wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: context aware concurrent S3 #201

bpeng wants to merge 2 commits into from
+322 −35

Conversation

@bpeng
Copy link
Contributor

@bpeng bpeng commented Jan 6, 2026 •
edited
Loading

Proposed Changes

Changes proposed in this pull request:

  • Add context in S3 GetAllConcurrently function to allow handle context cancel

Production Changes

The following production changes are required to deploy these changes:

  • None

Review

Check the box that applies to this code review. If necessary please seek help with adding a checklist guide for the reviewer.
When assigning the code review please consider the expertise needed to review the changes.

  • This is a content (documentation, web page etc) only change.
  • This is a minor change (meta data, bug fix, improve test coverage etc).
  • This is a larger change (new feature, significant refactoring etc). Please use the code review guidelines to add a checklist below to guide the code reviewer.

Code Review Guide

@bpeng bpeng requested a review from wilsonjord January 6, 2026 23:31
wilsonjord
wilsonjord reviewed Jan 7, 2026
View reviewed changes
Copy link
Contributor

@wilsonjord wilsonjord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Do you think these new Context functions should be in the tests?

@bpeng bpeng force-pushed the s3-update branch 15 times, most recently from a181f6c to 2630db5 Compare January 10, 2026 17:59
@bpeng bpeng changed the title feat: add context in s3 Get functions feat: context aware concurrent S3 Jan 11, 2026
@bpeng bpeng marked this pull request as draft January 11, 2026 04:10
@bpeng bpeng marked this pull request as ready for review January 25, 2026 21:56
@bpeng bpeng requested a review from CallumNZ January 25, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilsonjord wilsonjord wilsonjord left review comments

@CallumNZ CallumNZ Awaiting requested review from CallumNZ

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bpeng @wilsonjord