Changes required for Noble #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package was pushed to the ppa about 2 years ago, but I forgot to commit this final minor change.
cianwilson
approved these changes
Nov 7, 2025
Contributor
cianwilson
left a comment
cianwilson
left a comment
There was a problem hiding this comment.
Looks good to me (aside from one small verbose flag question).
Tested on mac os with homebrew python 3.14 after some assistance from @stephankramer to get distutils installed.
debian/rules
Outdated
| #!/usr/bin/make -f | ||
|
|
||
| #export DH_VERBOSE=1 | ||
| export DH_VERBOSE=1 |
Contributor
Author
There was a problem hiding this comment.
Yeah, not sure why this was changed (the 1.2.1 changes were 2 years ago already), I'll revert it back
Contributor
Author
|
Thanks, @cianwilson ! I've also pushed this to the fluidity supporting software PPA so you should be able to get this via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines minor Debian package change 1.2.1
with a number of minor fixes to support python 3.12.
The changes in python libspud were required to port fluidity to Noble (and will be backported in its libspud copy)
Changes in diamond appear to give basic functionality in opening diamond with a fluidity schema and setting some options in python 3.12 and 3.13