-
Notifications
You must be signed in to change notification settings - Fork 1
Update commons-demo to 5.1.0 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using this condition attribute, styles source code will be shown depending on the vaadin version.
WalkthroughThis PR updates a dependency version in pom.xml from 5.0.0 to 5.1.0 and adds Vaadin version-specific conditions to three CSS resource annotations in StyledBadgesDemo, enabling version-dependent CSS file loading in the demo. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pom.xml`:
- Line 21: The pom currently pins the property flowingcode.commons.demo.version
to a non-existent release (5.1.0); change the property value for
flowingcode.commons.demo.version from 5.1.0 to the published 5.0.0 so builds can
resolve the dependency, and verify demo classes that rely on the `condition`
attribute (e.g., StyledBadgesDemo.java) remain compatible with version 5.0.0.



Summary by CodeRabbit
Chores
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.