Skip to content

Conversation

@paodb
Copy link
Member

@paodb paodb commented Jan 19, 2026

Summary by CodeRabbit

  • Chores

    • Updated core dependency to version 5.1.0.
  • Improvements

    • Enhanced component styling with version-specific resource support for broader compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

paodb added 2 commits January 19, 2026 14:29
Using this condition attribute, styles source code will be shown depending on the vaadin version.
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

This PR updates a dependency version in pom.xml from 5.0.0 to 5.1.0 and adds Vaadin version-specific conditions to three CSS resource annotations in StyledBadgesDemo, enabling version-dependent CSS file loading in the demo.

Changes

Cohort / File(s) Summary
Dependency Version Update
pom.xml
Updated flowingcode.commons.demo.version property from 5.0.0 to 5.1.0
Demo Annotation Conditionals
src/test/java/com/flowingcode/vaadin/addons/badgelist/StyledBadgesDemo.java
Added version condition attributes to three @DemoSource annotations: first CSS resource with condition "vaadin eq 24", second CSS resource with caption change and condition "vaadin ge 25", third CSS resource with condition "vaadin ge 25"

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • javier-godoy
  • mlopezFC
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the commons-demo dependency from 5.0.0 to 5.1.0 in pom.xml, which is the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pom.xml`:
- Line 21: The pom currently pins the property flowingcode.commons.demo.version
to a non-existent release (5.1.0); change the property value for
flowingcode.commons.demo.version from 5.1.0 to the published 5.0.0 so builds can
resolve the dependency, and verify demo classes that rely on the `condition`
attribute (e.g., StyledBadgesDemo.java) remain compatible with version 5.0.0.

@paodb paodb requested a review from javier-godoy January 19, 2026 17:56
@paodb paodb marked this pull request as ready for review January 19, 2026 17:56
@javier-godoy javier-godoy merged commit fcb6182 into master Jan 19, 2026
4 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 19, 2026
@javier-godoy javier-godoy deleted the commons-demo-updates branch January 19, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

3 participants