#2692 Add ability to attach public key #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosnovsky
reviewed
Oct 20, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
works well, just a couple minor issues 👍
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+Attachment.swift
Outdated
Show resolved
Hide resolved
FlowCrypt/Functionality/Services/Compose Message Helper/ComposeMessageHelper.swift
Show resolved
Hide resolved
sosnovsky
reviewed
Oct 30, 2025
FlowCrypt/Controllers/Compose/Extensions/ComposeViewController+Attachment.swift
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@sosnovsky Ping you in case you missed this PR. |
Collaborator
Author
|
Also please update assignes. |
sosnovsky
approved these changes
Nov 17, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
Works great now, thanks!
sosnovsky
deleted the
2692-add-ability-to-attach-public-key-to-email-message
branch
Collaborator
@ioanatflowcrypt please check #2688 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added ability to attach public key
close #2692 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):