#6128 Use stripped url for exception #6131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosnovsky
reviewed
Dec 10, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
not sure that this solution will work - it splits URLs using ? as in the previous implementation, while this issue is for URLs which doesn't have ?:
https://mail.google.com/mail/u/0/#inbox/WhctKLbvMNLndrHSj...
https://mail.google.com/mail/u/0/#sent/KtbxLzFrMS...
https://mail.google.com/mail/u/1/#inbox/rtjXfHsNNgrJVZL...
https://mail.google.com/mail/u/1/#search/MSCGwzQrb...
and let's also add test for such type of URLs, to be sure that they're grouped correctly.
ioanatflowcrypt
commented
Dec 10, 2025
…' of https://github.com/FlowCrypt/flowcrypt-browser into 6128-use-stripped-url-for-exceptions-from-mailgooglecom
sosnovsky
approved these changes
Dec 16, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
all good now, thanks!
sosnovsky
deleted the
6128-use-stripped-url-for-exceptions-from-mailgooglecom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses stripped url for exception
close #6128 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):