Skip to content

Add an overload to xxhash to allow it to take a string constant #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrentHouliston merged 4 commits into from
Sep 3, 2025
Merged

Add an overload to xxhash to allow it to take a string constant #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7adc7bb
Add an overload to xxhash to allow it to take a string constant
TrentHouliston Sep 2, 2025
f280e2b
Make work with types
TrentHouliston Sep 3, 2025
43f5ad3
Refactor xxhash template functions to use fixed seed parameter
TrentHouliston Sep 3, 2025
7fc76e6
Add overloads for xxhash32 and xxhash64 to accept string literals
TrentHouliston Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/util/serialise/xxhash.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ namespace util {
uint32_t xxhash32(const char* input, const size_t& length, const uint32_t& seed = 0);

template <typename T>
uint32_t xxhash32(const T* input, const uint32_t& seed = 0) {
return xxhash32(reinterpret_cast<const char*>(input), sizeof(T), seed);
uint32_t xxhash32(const T& input, const uint32_t& seed = 0) {
return xxhash32(reinterpret_cast<const char*>(&input), sizeof(T), seed);
}
template <uint32_t S = 0, size_t N>
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
uint32_t xxhash32(const char (&input)[N]) {
return xxhash32(input, N - 1, S);
}

/**
Expand All @@ -62,8 +67,13 @@ namespace util {
uint64_t xxhash64(const char* input, const size_t& length, const uint64_t& seed = 0);

template <typename T>
uint64_t xxhash64(const T* input, const uint64_t& seed = 0) {
return xxhash64(reinterpret_cast<const char*>(input), sizeof(T), seed);
uint64_t xxhash64(const T& input, const uint64_t& seed = 0) {
return xxhash64(reinterpret_cast<const char*>(&input), sizeof(T), seed);
}
template <uint64_t S = 0, size_t N>
// NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays)
uint64_t xxhash64(const char (&input)[N]) {
return xxhash64(input, N - 1, S);
}

} // namespace serialise
Expand Down
Loading
Loading