Finished enhancing the CropSelector example #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Pull Request Description** Adds a log category for harvests. The code to add the category is in the module's `.install` file. Also added is a script that will uninstall and reinstall the `farm_fd2` module. This is useful when working on the module files. It is necessary because `farm_fd2` adds custom fields and drupal will not allow it to uninstalled while those fields exist. So this script deletes those fields, uninstalls `farm_fd2`, builds `farm_fd2`, and then reinstalls `farm_fd2`. --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents.
Reverts FarmData2#546 Forgot to fix the test suite to account for the new log category.
**Pull Request Description** - Adds a `harvest` category to the "log categories" taxonomy. - Adds a script to reinstall the `farm_fd2` module. - Needed because `farm_fd2` adds custom fields and drupal will not allow it to be uninstalled because data would be deleted. - The script deletes the custom fields, uninstalls the module, rebuilds the module, and then reinstalls the module. - Patches the tests for the log categories functions in the `farmosUtil` library. --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents.
Fix typos **Pull Request Description** Fixes 4 visible typos and one in comments --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents. Signed-off-by: atap <55597131+aarontapper@users.noreply.github.com>
A new Debian base image was released that was not compatible with the Docker-In-Docker features. This patch pegs the base image being used to be compatible with the version of the Docker-in-Docker feature that is installed. **Pull Request Description** _Describe what your Pull Request does here_ _Include a "Closes #" line for the issue your PR closes._ --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents. Signed-off-by: Grant Braught <braught@dickinson.edu>
Patches the .devcontainer to reveal the terminal in which VSCode tasks are running. This appears to be a change in how GitHub codespaces execute the VSCode tasks. If the terminal was not revealed the first task would fail and no further tasks would run. Revealing the terminal window solved this issue. --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents. Signed-off-by: Grant Braught <braught@dickinson.edu>
Update the install directions for the Codespaces approach to indicate that a terminal window will appear and can be ignored. --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents. Signed-off-by: Grant Braught <braught@dickinson.edu>
…ta2#568) **Pull Request Description** Updates the pull request template and adds separate templates for feature requests and bug reports. Closes FarmData2#229 --- **Licensing Certification** FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **I certify that I satisfy the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents.
### Purpose Adds the `bugInfo.bash` script. This script is run to generate some useful information about the current state of the `development` branch when a bug report is being filed. The Bug Report template now requests that output of this script as part of the bug report. ### Licensing Certification FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **the contributor (and any listed co-authors) certify that they meet the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents.
…ata2#571) ### Purpose Adds the execute permission to the script. ### Licensing Certification FarmData2 is a [Free Cultural Work](https://freedomdefined.org/Definition) and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request **the contributor (and any listed co-authors) certify that they meet the terms of the [Developer Certificate of Origin](https://developercertificate.org/)** for its contents.
braughtg
force-pushed
the
fd2-hackathon-quan
branch
from
a0be19f to
f0044cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A clear and concise description of the purpose of this pull request.
Verification steps
A clear and concise set of steps that will enable the reviewer to manually verify that this pull request accomplishes its purpose.
Approach
A clear and concise description of the approach taken with rationale for design decisions that were made.
Testing
A clear and concise description of automated tests that have been modified or added to verify changes that were made.
Related issues
Include "Relates to #" and/or "Closes #" lines to link to issues connected to this pull request.
Additional information
Include any additional information you think might be helpful here.
Licensing Certification
FarmData2 is a Free Cultural Work and all accepted contributions are licensed as described in the LICENSE.md file. This requires that the contributor holds the rights to do so. By submitting this pull request I certify that I satisfy the terms of the Developer Certificate of Origin for its contents.