Suggestion to removal further minor inconsistencies #15
Conversation
There was a problem hiding this comment.
The software pynxtools that other build it, therefore more leaning towards the passive interpretation
| site_description: | | ||
| The documentation for the {{cookiecutter.__package_name}} plugin. | ||
| site_author: The FAIRmat authors | ||
| site_author: The NOMAD Authors |
There was a problem hiding this comment.
That flabbergasted me, typically in many other places in pynxtools official plugins we use the "NOMAD" authors, also in the license, people sure need to change this is they dont develop an official fairmat plugin
There was a problem hiding this comment.
Probably, we can just go with {{cookiecutter.author_name}}, then it is auto-adjusted?
| site_author: The NOMAD Authors | |
| site_author: {{cookiecutter.author_name}} |
There was a problem hiding this comment.
For pytest.yml we run a matrix for pylint we havent done this yet but makes sense
There was a problem hiding this comment.
I wanted to avoid this because ruff anyway checks the pyproject file for the allowed python version and adjusts its behavior accordingly. An example is that once we dropped python<3.10, the default notation in ruff automatically changed from Optional[str] to str | None, which was introduced in python 3.10. So I think it's fine to use a single python version here.
lukaspie
left a comment
lukaspie
left a comment
There was a problem hiding this comment.
Just a couple suggestions
No description provided.