[Feature] [Move] Unit test gas usage #328
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SchedulerV2 & tests, refactor to use Statuses * addressing comments
…r bitvector number types (aptos-labs#16693) * add cast * add intrisic for borrow_with_default and support for smart table for bv analysis * fix
Co-authored-by: Igor <igor-aptos@users.noreply.github.com>
…t during type checking (aptos-labs#16768)
I removed logic for OpenSSL v1. It's been deprecated for a while now.
* replay-verify: print mismatches as found. also enlarge timeout to allow pods finish on mismatch * smaller range * timeout * print verify timeout message * More memory and split heavy ranges --------- Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
…os-labs#16739) * [cli] Update CLI build script to run with SH, and more platforms * [cli] fix emerge support * [cli] Add cargo install script for specific versions
…ptos-labs#16734) * Early refactors (structure / executor) for BlockSTMv2 * Addressing comments
* improve error message * refactor code
…rides the VestingContract type (aptos-labs#16054)
Ends up cleaning the PipelineBlock to make sure it's only shared with Arc instead of cloning, so we can abort the pipeline upon drop.
- Display implementation of tags is removed - `to_canonical_string()` should be used instead - Fixes conversion of function tags to strings
* abort function name fix in rest api * printing out instruction as well --------- Co-authored-by: Igor <igor-aptos@users.noreply.github.com>
* Add missed comments * [Orderbook] Add trigger condition to the order event * update
…ptos-labs#17147) * [move-vm] Adding negative FV tests for bytecode and runtime verifier This adds a number of tests (wrong code) which are run in two ways: one with bytecode verifier enabled where expect it to be caught in the verifier, one with bytecode verifier disabled where we expect it to be called by paranoid mode. One bug was discovered this far by this approach, where paranoid mode seems to miss a check (aptos-labs#17137). Also changes the way how the verifier is disabled by using a configuration option. The failpoints used before can't be used with parallel test execution. * Fixing false positive bug aptos-labs#17137 (actually a bug in the tests), cleaning up. * Apply suggestions from code review * Addressing reviewer comments
aptos-labs#17172) * [move-vm] Fix issue in function value upgrade compatibility, add tests Fixes aptos-labs#17171. Also adds more negative tests based on MASM for upgrade checks with function values. * Modify transactional test framework such that compatibility check is disabled in paranoid tests. This allows to check how paranoid mode deals with incompatible upgrades. Notice that the code need to be executed for this, this only effects the test case `compatibility_bug_17171.masm`. * Adding a test for dependency compatibility checking. * Addssing reviewer comments * Feature gating. Also removing some change in txn test runner smuggled accidentally into here.
* [move-vm] Some fixes for runtime checks - The captured argument types are no checked _before_ the LazyFunction is constructed, which requires to construct layous. Thus a more descriptive error will be produced then failure in layout construction. - Types of returned values of a function are checked explicitly. Before, those types would have been checked at some later point implicitly, when the returned values are used. Moreover, a returned value's type is adjusted to function's declared return type. Though the current behavior isn't wrong, the adjusted behavior is more aligned with what the bytecode verifier does. * Making return type check and replacement a bit more performant by skipping if not a variant types * Update third_party/move/move-vm/runtime/src/interpreter.rs Co-authored-by: Vineeth Kashyap <vineeth.rv@gmail.com> --------- Co-authored-by: Vineeth Kashyap <vineeth.rv@gmail.com>
- Refactor type to layout conversion - Support layout construction using the new loader
This was originally done in aptos-labs#16485. However, subsequent changes (mostly priority fee implementation) undid some of the changes, so while `BlockHotStateOpAccumulator` still computes `slots_to_make_hot`, the result is never populated to the hot state storage. Therefore, the read-only keys are never cached. This change populates the information again by putting it inside `BlockOutput`, and eventually merge it with the epilogue's write set. One tricky thing is that the read write summary can sometimes be inaccurate. For example, occasionally a key is written to, but it's not in the write summary, then the code would generate both a `Modification` op and a `MakeHot` op for the same key. To be defensive, if `Creation`/`Modification`/`Deletion` is followed by `MakeHot` on the same key when computing `BatchedStateUpdateRefs`, we have to discard the `MakeHot`.
…aptos-labs#16883) * [staking_contract] add view function to get staker given pool address * Update staking_contract.move
…ptos-labs#17256) * [verifier] Check for function signatures (aptos-labs#17210) (cherry picked from commit 3b81823) --------- Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com>
(cherry picked from commit d360385) Co-authored-by: George Mitenkov <georgemitenk0v@gmail.com>
aptos-labs#17284) (aptos-labs#17286) (cherry picked from commit ae54b1d) Co-authored-by: Guoteng Rao <3603304+grao1991@users.noreply.github.com>
…s#17296) (aptos-labs#17298) (cherry picked from commit c9bdfb4) Co-authored-by: Guoteng Rao <3603304+grao1991@users.noreply.github.com>
… (aptos-labs#17318) (cherry picked from commit 52fad82) Co-authored-by: Balaji Arun <balaji@aptoslabs.com>
Co-authored-by: hariria <31301117+hariria@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves https://github.com/Entropy-Foundation/smr-moonshot/issues/2543