Core: Introduce cross-platform npm restore and check mismatch on publish #988
+167
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-comment: Run #2
🎉 All tests passed!Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
softworkz
force-pushed
the
submit_crossdebug
branch
from
c4f8292 to
9d03787
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
Show resolved
Hide resolved
src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
Show resolved
Hide resolved
src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
Show resolved
Hide resolved
src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
Show resolved
Hide resolved
Collaborator
Author
I need a package 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may seem contradictive at first sight.. :-)
It does this:
This has caused user confusion because it can too easily be gotten wrong. Now it's no longer possible to build for OS A on OS B.
One exception: Linux packages can be build on Windows (WSL)
npm installThis means for example: When you are on Windows and osx-x64 is selected as RID, then the npm restore will do the restore as if it was on OSX.
In case of mismatch, it exists with an appropriate error message
(it would fail anyway, but without explanation otherwise)
So - why do x-platform npm restore first and then error out on platform mismatch when publishing?
It's all about debugging - remote debugging. And again, the fast way is of course without packaging - i.e. how debug is working now. For remote debugging, we need to have everything ready to work on the target/remote machine. For .net it's not a problem anyway, but the Electron executable is platform-dependent, This PR allows to get the right one, so that we can end up with a file set which runs on the target direct.ly, without any additional steps needed.