Skip to content

Conversation

@JP0P
Copy link
Collaborator

@JP0P JP0P commented Dec 31, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Strengthens reliability of the Add/Edit tokens Maestro test and validates token persistence.

  • Adds token search flow and selects 1INCH via indexed match; clears search with undefined.clearIcon
  • Splits contract address input for UNI/MOG to avoid fast-typing issues and verifies autocomplete (code/name/decimals)
  • Handles existing built-in token modal for UNI; proceeds to add custom MOG and confirms visibility
  • Dismisses iOS keychain prompt (Not Now) post-relogin and verifies tokens persist after relaunch
  • Minor wait/timeout adjustments and cleanup of redundant steps

Written by Cursor Bugbot for commit c303bc6. This will update automatically on new commits. Configure here.


@JP0P JP0P force-pushed the jared/maestro-small-fix branch 3 times, most recently from 23cad22 to d90afb9 Compare December 31, 2025 01:18
# - runFlow:
# file: ../common/import-wallets.yaml
# env:
# ASSET_NAMES: "Ethereum"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test setup flows commented out breaks entire test

The essential test setup flows (launch-cleared.yaml, create-account.yaml, dismiss-modals.yaml, and import-wallets.yaml) have been commented out. This causes the test to fail because: (1) there's no account or ETH wallet to interact with when the test tries to tap "Assets" and scroll to "ETH", and (2) later in the file (lines 147-150), the test attempts to log in using ${output.newAccountUsername} and ${output.newAccountPassword} which are only populated by the now-commented-out create-account.yaml flow. This appears to be debug code that was accidentally committed.

Fix in Cursor Fix in Web

@JP0P JP0P force-pushed the jared/maestro-small-fix branch 2 times, most recently from d79b9db to 927d4de Compare December 31, 2025 01:23
@JP0P JP0P force-pushed the jared/maestro-small-fix branch from 927d4de to d2a640f Compare December 31, 2025 07:47
@JP0P JP0P force-pushed the jared/maestro-small-fix branch from d2a640f to c303bc6 Compare December 31, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants