dev: lint with ruff #211
Open
dev: lint with ruff #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
(test failure is just codecov rate limiting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up to lint with
ruff.I'm hestitant to move tooling again (it's the old joke about python), but I've been using
ruffanduvfor several years now at work and I really do think they're both a net improvement and here to stay.This PR just replaces black / isort with ruff, and cleans up all the fluff ruff found (dead code mostly, but also the odd pointless f-string and the like).
If you've not used it, ruff is very fast (milliseconds: really), and very easy to install, so I really think we should use it (possibly turning on more lints if needed going forward).
I've added a ci flow to test lints.