Skip to content

Conversation

@jacob720
Copy link
Contributor

@jacob720 jacob720 commented Dec 9, 2025

Fixes DiamondLightSource/mx-bluesky#1504
DNM - requires future features of daq-config-server

Required by DiamondLightSource/mx-bluesky#1511

Instructions to reviewer on how to test:

  1. Test beamline parameters files are not read from the file system in dodal

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner December 9, 2025 10:44
@jacob720 jacob720 marked this pull request as draft December 9, 2025 10:44
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.13%. Comparing base (e0d5a17) to head (8f87171).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
- Coverage   99.14%   99.13%   -0.01%     
==========================================
  Files         288      288              
  Lines       10937    10920      -17     
==========================================
- Hits        10843    10826      -17     
  Misses         94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacob720 jacob720 marked this pull request as ready for review January 12, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate beamline paramaters to use the daq-config-server

2 participants