Skip to content

Conversation

@dependabot-preview
Copy link
Contributor

Bumps shoulda-matchers from 2.7.0 to 3.1.2.

Release notes

Sourced from shoulda-matchers's releases.

v3.1.2

Deprecations

  • This is the last version that supports Rails 4.0 and 4.1 and Ruby 2.0 and 2.1.

Bug fixes

  • When the permit matcher was used without #on, the controller did not use
    params#require, the params object was duplicated, and the matcher did not
    recognize the #permit call inside the controller. This behavior happened
    because the matcher overwrote double registries with the same parameter hash
    whenever ActionController::Parameters was instantiated.

Changelog

Sourced from shoulda-matchers's changelog.

3.1.2

Deprecations

  • This is the last version that supports Rails 4.0 and 4.1 and Ruby 2.0 and
    2.1.

Bug fixes

  • When the permit matcher was used without #on, the controller did not use
    params#require, the params object was duplicated, and the matcher did not
    recognize the #permit call inside the controller. This behavior happened
    because the matcher overwrote double registries with the same parameter hash
    whenever ActionController::Parameters was instantiated.

3.1.1

Bug fixes

  • Some matchers make use of ActiveSupport's in? method, but do not include the
    file where this is defined in ActiveSupport. This causes problems with
    projects using shoulda-matchers that do not include all of ActiveSupport by
    default. To fix this, replace in? with Ruby's builtin include?.

    • Pull request: [#879]
  • validate_uniqueness_of works by creating a record if it doesn't exist, and
    then testing against a new record with various attributes set that are equal
    to (or different than) corresponding attributes in the existing record. In
    3.1.0 a change was made whereby when the uniqueness matcher is given a new
    record and creates an existing record out of it, it ensures that the record is
    valid before continuing on. This created a problem because if the subject,
    before it was saved, was empty and therefore in an invalid state, it could not
    effectively be saved. While ideally this should be enforced, doing so would be
    a backward-incompatible change, so this behavior has been rolled back.
    ([#880], [#884], [#885])

    • Commit: [45de869]
    • Issues: [#880], [#884], [#885]
  • Fix an issue with validate_uniqueness_of + scoped_to when used against a
    model where the attribute has multiple uniqueness validations and each

... (truncated)
Commits
  • 1201198 Merge pull request #1034 from guialbuk/add-deprecation-notice-to-news-md
  • fe79af4 Add deprecation notice to NEWS.md
  • 2becfea Merge pull request #1030 from gitter-badger/gitter-badge
  • 3fa4c2e Add Gitter badge
  • ac9f482 Merge pull request #1014 from guialbuk/rails-5-readme
  • 6eb920a Add installation instructions for Rails 5.0
  • d3145e9 Update thoughtbot logo
  • e8f1492 Update .rubocop.yml
  • 9416f68 Add note to README
  • 59dfb0e Bump version to 3.1.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Oct 22, 2018
gem "database_cleaner"
gem "launchy"
gem "shoulda-matchers", "~> 2.7.0"
gem "shoulda-matchers", "~> 3.1.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@dependabot-preview
Copy link
Contributor Author

Superseded by #473.

@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/shoulda-matchers-3.1.2 branch February 20, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants