RN headless signing flow: default false #1479
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Multi wallet support * undo * fixbuild * praction * fmt * openapi * addChangeset
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* remove aspect-ratio for submit button * add changeset
* save * layout
* Adds export private key button to both react sdks * changeset * cleanup * show export in web demo * addesses hal-06
* Onramp: Supporting proof of ownership on Embedded Checkout * fix * PR Actions
… (WAL-7251) (#1473) * fix: add email normalization to signer validation for Gmail addresses - Add normalizeEmail() function that replicates backend normalization logic - Modify compareSignerConfigs() to normalize email values before comparison - Add comprehensive tests for Gmail dot normalization and case handling - Fixes WAL-7251: Users with dotted Gmail addresses can now retrieve wallets without validation errors Co-Authored-By: Guille <guille.a@paella.dev> * chore: add changeset for email signer validation fix Co-Authored-By: Guille <guille.a@paella.dev> * refactor: use isEmailValid for better email validation in signer comparison Co-Authored-By: Guille <guille.a@paella.dev> * chore: update pnpm-lock.yaml after adding common-sdk-auth dependency Co-Authored-By: Guille <guille.a@paella.dev> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* save * bump
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…1477) * Onramp: Loading crypto libraries when recipient verification needed * fix
* React Native sdk: add ui elements for signing flow * merge changes * added ui components for email and phone signers * update the expo demo to support both signer impls * fix headless state and handshake issue * update expo demo to default to signer ui * remove console logs * rename experimental_headlessSigningFlow to headlessSigningFlow * removed inline comments * remove prop on react-ui * added changeset * fix lint issue from rebase * comment out export keys button * fixed test * defaulted headlessSigningFlow to true
🦋 Changeset detectedLatest commit: b5a991b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For our version 1 release, we're going to default our react native signing UI to be displayed instead of developers existing headless UI.
Test plan
Package updates
@crossmint/client-sdk-react-native-ui