feat(comms)!: new communications module that merges SMS, Push and Email into a single service #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ants actions (#1135) * refactor(chat): sendInvitation props as object * fix(chat): missing populate query param from router * fix(chat): missing search message regex matching * chore(chat): cleanups * fix(chat): router invitation token count * refactor(chat): admin route createRoom participants logs, set creator * refactor(chat): participants actions * fix(chat): router query params id types * feat(chat): router remove member from room route * fix(chat): admin route getRooms missing params * fix(chat): admin route deleteRooms missing audit-mode config check * feat(chat): admin route removeUsers/addUsers/roomInvitations/roomById * feat(chat): participants join log on invitation accept
feat(comms): update code for new mailgun library
kon14
requested changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #122 merging the SMS, Push Notifications and Email modules into a single Comms module. The aim of this merge is to:
Tasks:
This is a breaking change, to be merged in v-next branch for version 0.17.x
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: