Tough love: Remove Terraform generation feature

[robert-chiniquy]

Remove TF generation feature (data sources provide and improve upon the extant functionality, and it is unused)

Summary by CodeRabbit

• Revert
  • Removed Terraform integration for apps, including configuration generation and resource mapping capabilities.
  • Removed Terraform support for entitlements with associated type definitions and helper methods.
  • Removed Terraform support for policies and policy configuration templates.
  • Removed the underlying Terraform templating framework and utilities used to generate infrastructure-as-code configurations.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Four Go files from pkg/terraform/ are deleted entirely: app.go, entitlement.go, policy.go, and templater.go. This removes AppTemplate, AppEntitlementTemplate, and PolicyTemplate types; their associated methods (GetRequired, GetType, GetId, GetResourceId, GetOutputId); the TemplateData interface; template utilities (ApplyTemplate, ApplyTemplates, ObjectNameToTerraformType); and related constants.

Changes

Cohort / File(s)

Change Summary

Terraform template types and utilities pkg/terraform/app.go, pkg/terraform/entitlement.go, pkg/terraform/policy.go, pkg/terraform/templater.go

Deleted four files. Removed AppTemplate, AppEntitlementTemplate, and PolicyTemplate structs with their methods (GetRequired, GetType, GetId, GetResourceId, GetOutputId). Removed TemplateData interface and template utility functions (ApplyTemplate, ApplyTemplates, ObjectNameToTerraformType). Removed constants TerraformAppType, TerraformAppEntilementType, TerraformPolicyType, resourcePrefix, and ImportTemplateString.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify no remaining codebase references to AppTemplate, AppEntitlementTemplate, PolicyTemplate, or TemplateData interface
• Check for any imports of these removed files or usage of deleted utility functions (ApplyTemplate, ApplyTemplates, ObjectNameToTerraformType)
• Confirm constants (TerraformAppType, TerraformAppEntilementType, TerraformPolicyType) are not referenced elsewhere

Poem

🐰 Four files bid us farewell today,
Templates and types have gone away,
App and entitlement, policy too—
Clean slate awaits, all fresh and new!
CodeRabbit hops through pruned git trees,
Saying goodbye with gentle ease. 🌿

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Tough love: Remove Terraform generation feature' directly and clearly summarizes the main change—removal of the Terraform generation feature across multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rch/tough-love/remove-terraform-generation-feature

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22e577c and 310d311.

⛔ Files ignored due to path filters (4)

• cmd/cone/main.go is excluded by none and included by none
• cmd/cone/terraform.go is excluded by none and included by none
• cmd/cone/terraform_flags.go is excluded by none and included by none
• cmd/cone/terraform_gen.go is excluded by none and included by none

📒 Files selected for processing (4)

• pkg/terraform/app.go (0 hunks)
• pkg/terraform/entitlement.go (0 hunks)
• pkg/terraform/policy.go (0 hunks)
• pkg/terraform/templater.go (0 hunks)

💤 Files with no reviewable changes (4)

• pkg/terraform/entitlement.go
• pkg/terraform/templater.go
• pkg/terraform/policy.go
• pkg/terraform/app.go

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}