Show new partial sync data. #63
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ConsoleManager
participant SyncOutput
User->>ConsoleManager: Request sync runs output
ConsoleManager->>SyncOutput: Retrieve sync run data (including sync_type, parent_sync_id)
ConsoleManager->>User: Display table with ID, Type, Parent ID, Started At, Ended At, Token
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/output/console.go (1)
56-56: Table header updated with new columnsThe header now includes the new "Type" and "Parent ID" columns to display the sync type and parent sync ID.
Consider explicitly declaring the type for the table data slice to address the static analysis warning:
- syncsTable := pterm.TableData{ + syncsTable := pterm.TableData{Note: This is a minor stylistic suggestion that doesn't affect functionality.
🧰 Tools
🪛 golangci-lint (1.64.8)
56-56: missing type in composite literal
(typecheck)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (38)
buf.gen.yamlis excluded by none and included by nonecmd/baton/syncs.gois excluded by none and included by nonego.sumis excluded by!**/*.sumand included by nonepb/baton/v1/outputs.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/baton/v1/outputs.pb.validate.gois excluded by!pb/**and included by nonepb/c1/connector/v2/entitlement.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/c1/connector/v2/entitlement.pb.validate.gois excluded by!pb/**and included by nonepb/c1/connector/v2/entitlement_grpc.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/c1/connector/v2/grant.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/c1/connector/v2/grant.pb.validate.gois excluded by!pb/**and included by nonepb/c1/connector/v2/grant_grpc.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/c1/connector/v2/resource.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonepb/c1/connector/v2/resource.pb.validate.gois excluded by!pb/**and included by nonepb/c1/connector/v2/resource_grpc.pb.gois excluded by!**/*.pb.go,!pb/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/connector.pb.gois excluded by!**/*.pb.go,!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/event_feed.pb.gois excluded by!**/*.pb.go,!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/event_feed.pb.validate.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/resource.pb.gois excluded by!**/*.pb.go,!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/resource.pb.validate.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/connector/v2/resource_grpc.pb.gois excluded by!**/*.pb.go,!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/reader/v2/sync.pb.gois excluded by!**/*.pb.go,!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pb/c1/reader/v2/sync.pb.validate.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/connectorstore/connectorstore.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/assets.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/c1file.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/entitlements.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/grants.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/resouce_types.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/resources.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/sql_helpers.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/dotc1z/sync_runs.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/pagination/generic_bag.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/pagination/pagination.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/sdk/version.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/uhttp/pagination.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/uhttp/transport.gois excluded by!vendor/**and included by nonevendor/github.com/conductorone/baton-sdk/pkg/uhttp/wrapper.gois excluded by!vendor/**and included by nonevendor/modules.txtis excluded by!vendor/**and included by none
📒 Files selected for processing (3)
go.mod(1 hunks)pkg/output/console.go(1 hunks)proto/baton/v1/outputs.proto(1 hunks)
🧰 Additional context used
🪛 golangci-lint (1.64.8)
pkg/output/console.go
56-56: missing type in composite literal
(typecheck)
🔇 Additional comments (3)
go.mod (1)
6-6: Dependency update looks goodThe update of
baton-sdkfrom a previous version tov0.3.0aligns with the new fields added to theSyncOutputprotobuf message.proto/baton/v1/outputs.proto (1)
99-100: Fields added correctly to the SyncOutput messageThe new
sync_typeandparent_sync_idfields are properly added with sequential field numbers (5 and 6) and follow protobuf naming conventions.pkg/output/console.go (1)
64-66: Added new sync fields to table outputThe table output now correctly includes the
SyncTypeandParentSyncIdfields, which completes the implementation of displaying the new sync data.
ggreer
force-pushed
the
ggreer/partial-sync
branch
from
cfea61a to
56ea1c0
Compare
Summary by CodeRabbit