Skip to content

Conversation

@johnallers
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • .github/workflows/release.yaml is excluded by none and included by none
  • .gon-amd64.json is excluded by none and included by none
  • .gon-arm64.json is excluded by none and included by none
  • .goreleaser.docker.yaml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jallers/fix-release

Comment @coderabbitai help to get the list of available commands and usage tips.

@johnallers johnallers marked this pull request as draft November 17, 2025 21:36
@johnallers johnallers marked this pull request as ready for review November 18, 2025 15:45
Copy link

@luisina-santos luisina-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to add Dockerfile.lambda here?

Example: https://github.com/ConductorOne/baton-gitlab/blob/main/Dockerfile.lambda

@johnallers
Copy link
Contributor Author

do you need to add Dockerfile.lambda here?

Example: https://github.com/ConductorOne/baton-gitlab/blob/main/Dockerfile.lambda

@luisina-santos I don't know. I tested a release without it and worked:

https://github.com/ConductorOne/baton-sql-server/actions/runs/19471843491/job/55721041298

Maybe because lambda is set to false?

@johnallers
Copy link
Contributor Author

do you need to add Dockerfile.lambda here?
Example: https://github.com/ConductorOne/baton-gitlab/blob/main/Dockerfile.lambda

@luisina-santos I don't know. I tested a release without it and worked:

https://github.com/ConductorOne/baton-sql-server/actions/runs/19471843491/job/55721041298

Maybe because lambda is set to false?

I didn't do this to baton-active-directory and it has been fine, so I'm going to say that this is ok.

@johnallers johnallers merged commit 6d04bd9 into main Nov 18, 2025
12 checks passed
@johnallers johnallers deleted the jallers/fix-release branch November 18, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants