fix: parsing of booleans from config file #364
+17
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
Why
Boolean values in the config are expressed as strings. Wherever we work with them, we have to parse them correctly.
For example here:
The user has to be precise here with their config.
That also led to #337, which describes how tracking currently cannot be disabled, because we incorrectly parse the string by treating it as if it was a boolean in
tracking.py.What
I'm adding a
get_boolfunction to theConfigManagerto solve parsing booleans from config once. It's usingconfigparser's own mechanism to convert a string to a boolean and accepts additional values liketrue,yes,on,1case-insensitive.