Skip to content

Conversation

@KennethWussmann
Copy link

@KennethWussmann KennethWussmann commented Jan 28, 2026

Fixes #337

Why

Boolean values in the config are expressed as strings. Wherever we work with them, we have to parse them correctly.

For example here:

self.config["DEFAULT"][constants.CONFIG_KEY_ENABLE_TRACKING] == "True"

The user has to be precise here with their config.

That also led to #337, which describes how tracking currently cannot be disabled, because we incorrectly parse the string by treating it as if it was a boolean in tracking.py.

What

I'm adding a get_bool function to the ConfigManager to solve parsing booleans from config once. It's using configparser's own mechanism to convert a string to a boolean and accepts additional values like true, yes, on, 1 case-insensitive.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api.mixpanel.com tracking cannot be disabled with config variable

1 participant