annotation: use correct width property for position calculation #13956
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: referring #document-canvas as object here in Dekstop object.width and object.style.width are same but in tablet both are different and in these calculations later one is correct Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I959e8d1e0f7e89ea82b1eba9cdf5ddb675f8c869
Member
Author
|
It would be preffered that this PR is tested on a read tablet. In browser's responsive mode I had some DPI issue with caused comment width to be incorrect in section property but dev tools showed correct width which is weird. inshort before changing all the DPI equestion it would be nice to see how this works on a real tablet. Things to note here is when comment is selected it should just get fully into view and not stick to the commented word or overlap it. |
caolanm
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem:
referring #document-canvas as object here
in Dekstop object.width and object.style.width are same but in tablet both are different and in these calculations later one is correct
Change-Id: I959e8d1e0f7e89ea82b1eba9cdf5ddb675f8c869
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay