fix navigator comments being scrolled off #13953
Open
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com> Change-Id: If74cc69f9efc6a9c7fe4765b4d5a61cc71b8b118
[1] reduced the navigator sidebar width from 330px to 250px, but it
didn't take into account the overflow-x (which is hidden). when the
elements were inserted dynamically (by javascript), they got scrolled
off to the left side giving an impression that they are cut off.
this patch increases the width to 266px as at that width, no overflow-x
exists on navigator-dock-wrapper.
also change the impress/statusbar_spec as with the new increased width,
the zoom is not 70% but 60% at the test's window size.
--
[1] Reduce the navigator sidebar width and change bg color for navigator
85d604d
Signed-off-by: Sahil Gautam <sahil.gautam@collabora.com>
Change-Id: Iaf769bdce11dc27fa11af3f831f691bc2d6c9cad
printfdebugging
force-pushed
the
private/printfdebugging/navigator-comments-cut-off
branch
from
646f0cd to
6eea389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay