Feat: improve code quality and fix runtime argument passing bugs #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PHPStan static analysis and PHP CS Fixer for code quality - Fix FunctionValue::call method to use proper callable invocation - Correct ObjectValue built-in functions to accept $args array pattern - Fix method name inconsistencies (evaluateAsBool → asBool) across RuntimeValue classes - Add proper type validation and error handling in built-in functions - Establish consistent argument passing pattern for all RuntimeValue methods - Add GitHub Actions workflow for automated code quality checks - Support PHP 8.4 in CI/CD pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive code quality improvements using PHPStan and PHP CS Fixer, while simultaneously fixing critical bugs in the runtime argument passing system that were exposed through static analysis.
Motivation
The main motivation was to improve the codebase quality and catch subtle bugs that were not apparent during normal testing but were caught by PHPStan's static analysis.
What Changed
Breaking Changes
None - All fixes maintain backward compatibility while improving type safety and consistency.