-
Notifications
You must be signed in to change notification settings - Fork 0
New widget appearance #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # dist/doboard-widget-bundle.min.js # dist/doboard-widget-bundle.min.js.map
…ed them for the mobile version, added full links to tasks, added the ability to create tasks without linking to elements
js/src/widget.js
Outdated
| projectId: this.params.projectId, | ||
| accountId: this.params.accountId, | ||
| taskMeta: JSON.stringify(this.selectedData), | ||
| taskMeta: JSON.stringify(this.selectedData ? this.selectedData : {pageURL:"http://localhost/"}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is default pageURL correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, that was for testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
js/src/widget.js
Outdated
| this.createWidgetElement(this.type_name) | ||
| }) || ''; | ||
|
|
||
| // document.querySelector('#doboard_task_widget-task_count')?.addEventListener('click', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the unused code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
js/src/loaders/SpotFixSVGLoader.js
Outdated
| </svg>`; | ||
| } | ||
|
|
||
| // static logoDoBoardWhite() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An unnecessary code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And in css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected
https://app.doboard.com/1/task/38225