Skip to content

Conversation

@greilberger13
Copy link
Contributor

For the indentation two new messages/args are added to each script brick. One for the input statement and one for the advanced mode. To still pass all test cases, there were some adjustments needed in the rendering part. (utils.js, catroid.js & bricks.js)
Also a brick name is removed from the scriptBricks array in bricks.js, because it simply does not belong here.
Add tests for indentation and advanced mode in block.test.js and advanced-mode.test.js.

Your checklist for this pull request

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Make sure you use BLOCKS instead of CATROID in your commit message
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed (Actions)
  • Post a message in the #catblocks Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant