Skip to content

Conversation

@vinhdev17
Copy link
Contributor

No description provided.

@jchannon
Copy link
Member

Thanks! Can you add some tests to CarterExtenstionTests to assert we find internal modules?

@vinhdev17
Copy link
Contributor Author

Quote reply

I just added some tests 👍

@jchannon jchannon added this to the vNext milestone Nov 29, 2025
@jchannon
Copy link
Member

Can you change ResponseExtensions to have this negotiator = negotiators.First(x => x.GetType() == typeof(DefaultJsonResponseNegotiator)); when negotiator is null as it's pulling in the InternalResponseNegotiator you added

@vinhdev17
Copy link
Contributor Author

image

From what I observed, all negotiators are being resolved, including the test ones. To handle this scenario, I introduced new attributes to filter them out accordingly.
Let me know if this approach aligns with what you had in mind.

@jchannon
Copy link
Member

Thanks for your contribution! Great work 👍

@jchannon jchannon merged commit 817e48d into CarterCommunity:main Nov 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants