Skip to content

Conversation

@Seramis
Copy link
Member

@Seramis Seramis commented Jan 15, 2026

Description

  • Some readonly keywords were removed from methods that didn't need them.
  • Moved the length check out from TryFill() method and renamed it to Fill(). Length check is done now when necessary before Fill() is called.
  • Benchmarks were not affected.
  • Added one additional unittest for method call of Ulid.New(timestamp, random);.
  • Clarified ULID advantages over GUIDs, including UUIDv7 GUID, in README.md.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (please specify): Codestyle

Checklist

  • The PR is submitted to the correct branch (main).
  • My code follows the project's coding style. (.editorconfig)
  • I have commented my code, particularly in hard-to-understand areas and public interfaces.
  • I have added or updated tests for the changes I made.
  • All new and existing tests passed.
  • I have updated the documentation where applicable.

…d improve overall performance. Added additional test for Unix timestamp and random input validation.
…t monotonicity, and address limitations in UUIDv7 implementations.
@Seramis Seramis self-assigned this Jan 15, 2026
@Seramis Seramis merged commit 5aae8b0 into ByteAether:main Jan 15, 2026
7 checks passed
@Seramis Seramis deleted the small_optimizations branch January 15, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant