-
Notifications
You must be signed in to change notification settings - Fork 66
Added API layer for tool calls #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Daedaelius
wants to merge
8
commits into
main
Choose a base branch
from
feat/tool-calls-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
49a6e24
Added tracing metadata for LiteLLM provider
olesho 356fb31
Added lightweight deployment: dockerized devtools panel + external br…
Daedaelius 742a6b6
Tool calls expose as Agent Server API
Daedaelius 49216cf
Fix tool name
Daedaelius fccbc85
Merge remote-tracking branch 'origin/main' into feat/tool-calls-api
Daedaelius 5dd5464
Fix build error: fix ActionAgent references in GRD file
Daedaelius b5c08ad
Merge GRD fix into feat/tool-calls-api
Daedaelius 3f204a2
Fixed Docker image and agent server to support tool-calling through A…
Daedaelius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify connection readiness before tool execution.
The method doesn't validate that the connection is in a ready state before attempting RPC communication. If the connection isn't ready, the RPC call will fail with a less informative error.
🔎 Suggested validation
async executeToolDirect(connection, tool, args, timeout = 30000) { const rpcId = `tool-${Date.now()}-${Math.random().toString(36).substring(2, 9)}`; + if (!connection.ready) { + throw new Error(`Connection for client ${connection.clientId} is not ready for tool execution`); + } + logger.info('Executing tool directly', { clientId: connection.clientId, tool, timeout });📝 Committable suggestion